Fix fb_season_team_stats()
#390
Conversation
|
|
||
| # have included this to differentiate between how different leagues handle ladders/tables | ||
| league_tables <- season_stats_page %>% rvest::html_nodes("#content .table_wrapper") %>% rvest::html_elements("h2") %>% rvest::html_text() | ||
|
|
||
| # we either want to detect the presence of League Table or Regular season and get the index of that to be able to extractg the table we want | ||
| if(length(grep("league table", tolower(league_tables))) > 0) { | ||
| league_tables_idx <- grep("league table", tolower(league_tables)) | ||
| if(length(grep(competition_name, league_tables)) > 0) { |
There was a problem hiding this comment.
MLS is an ongoing league. We can see that "Regular Season" is still used, so we still need this if-else clause.
But for every other league that I checked, the competition name is now used for completed seasons.
There was a problem hiding this comment.
LGTM.
Thanks for addressing this one so quickly @tonyelhabr!
sd_meta.R
Outdated
There was a problem hiding this comment.
looks like an unintentionally committed file
|
@JaseZiv ah hold up, got one more code change i need to make 🤦 |
ok we're good now. needed to rename |
Awesome! Happy for me to wait until the checks have run before merging @tonyelhabr? |
only failing tests are for unrelated functions (transfermarket stuff, |
Fixes #389