-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle missing ieee_address #168
Conversation
Yes, I think this should fix the regression. Seems the old parameter was initially assigned int 0 and then assigned string. While argparse should be None and string |
Please merge this. |
Since a separate issue exists now: Fixes #172 |
Confirmed to work with ZBDongle-P which previously threw the exception. |
Can also confirm fixes |
I can also confirm that this error ist fixed with that PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and confirmed to work when reflashing my Sonoff-P.
It solved my issue, thx a lot !!!! |
Co-authored-by: Maximilian Mewes <[email protected]>
Fix for #162 (comment)