Skip to content

Commit

Permalink
Merge pull request #3 from Jeroeny/update
Browse files Browse the repository at this point in the history
commit hash should be string
  • Loading branch information
Jeroeny authored Oct 28, 2019
2 parents 40a8772 + fbaa6b6 commit 8ae8dea
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 10 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ vendor/
composer.lock

.phpunit.result.cache
.phpcs-cache
/.phpcs-cache
/.credentials.json
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Forked from [php-gitlab-api](https://github.com/jeroeny/gitlab-api) and based on
Installation
------------

Via [composer](https://getcomposer.org)
Using [composer](https://getcomposer.org):

```bash
composer require jeroeny/gitlab-api
Expand Down
4 changes: 4 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
],
"license": "MIT",
"authors": [
{
"name": "Jeroen Spee",
"homepage": "https://github.com/Jeroeny"
},
{
"name": "Matt Humphrey",
"homepage": "http://m4tt.io"
Expand Down
2 changes: 0 additions & 2 deletions src/Api/Repositories.php
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ public function updateRelease(int $project_id, string $tag_name, string $descrip
*/
public function releases(int $project_id)
{
$resolver = $this->createOptionsResolver();

return $this->get($this->getProjectPath($project_id, 'releases'));
}

Expand Down
2 changes: 1 addition & 1 deletion src/Model/Commit.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public static function fromArray(?Client $client, Project $project, array $data)
return $commit->hydrate($data);
}

public function __construct(Project $project, ?int $id = null, ?Client $client = null)
public function __construct(Project $project, ?string $id = null, ?Client $client = null)
{
$this->setClient($client);
$this->setData('project', $project);
Expand Down
6 changes: 1 addition & 5 deletions src/Model/Model.php
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,7 @@ public function __get(string $property)
));
}

if (isset($this->data[$property])) {
return $this->data[$property];
}

return null;
return $this->data[$property] ?? null;
}

public function __isset(string $property): bool
Expand Down

0 comments on commit 8ae8dea

Please sign in to comment.