-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect pandoc urls from github api #372
base: master
Are you sure you want to change the base?
Conversation
Hey @nstrmx thanks for the PR. Can you take a look at the failing checks. Do you think it's a PR issue, or something else? |
fe9e4ad
to
188d739
Compare
Fixed it (hopefully). |
Interestingly @nstrmx it seems that the single test failing, is actually because of a 403 rate limit. |
If we add support for the GITHUB_TOKEN as an environment variable to be used in requests, will that solve this? |
yes, that would be acceptable. But I feel like that if that key isn't set, we should fall back to the old behaviour. |
Add support for GITHUB_TOKEN
Update master
Update version
Should work now. |
Great work. Lastly, since we now should have 2 download behaviors, we should probably make a test casefor each behavior |
No description provided.