Update GrammarCells constraint checks to fix empty completion menus #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dummy nodes were created too early, leading to artifically failing constraints.
alexanderpann
requested changes
Nov 6, 2023
The empty menu was triggered by whitelisting concepts in constraints.
Done in latest commit. |
alexanderpann
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes from #664 were causing some completion menus to become empty since the constraints were not set up to check for abstract dummy nodes. This PR addresses this issue by moving the earlier constraint test back to its original version. The filtering is then performed when building the concrete action list.