Mill support: enable importing projects which contain build.mill(.scala) but not wrapper script #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…la) but not wrapper script Not all Mill projects necessarily have a wrapper script in the root. The wrapper script may be on the PATH. But _all_ Mill projects contain `build.mill` or `build.mill.scala`, so that's _the_ robust way to recognize them.
|
What about pre-0.12 projects, they would have |
|
They would need to update to >= 0.12? My attitude towards this is "who cares about old Mill"? But if there's an actual demand, I'm not opposed. And the change is trivial, so I actually did it :) |
lefou
added a commit
to lefou/mill
that referenced
this pull request
Nov 19, 2024
This info may be still valuable to debug IDE issues as well as running with more rare setups like `vim` or `emacs`. Inspired by JetBrains/intellij-scala#674 from https://github.com/sideeffffect
|
"old mill" Right now I'm blocked on com-lihaoyi/mill#3955, which was fixed but needs to be released as 0.12.3 |
|
@nafg fair enough. Btw I thought I did it, but I didn't, so I've made the change now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all Mill projects necessarily have a wrapper script in the root. The wrapper script may be on the PATH.
But all Mill projects contain
build.millorbuild.mill.scala, so that's the robust way to recognize them./cc @lihaoyi