Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race in packageArtifact for doPatchPluginXml #124

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Fix race in packageArtifact for doPatchPluginXml #124

merged 2 commits into from
Jan 19, 2024

Conversation

kellen
Copy link
Contributor

@kellen kellen commented Oct 26, 2023

When running packageArtifact, doPatchPluginXml fails to patch the xml because it races w/ packageMappings

@kellen kellen mentioned this pull request Oct 26, 2023
Merged
@unkarjedy
Copy link
Member

Thanks for the contribution!
Could you please add a simple line comment above Def.sequential explaining why it's essential?
And we will merge it right away.

@unkarjedy unkarjedy self-requested a review January 17, 2024 12:27
@kellen
Copy link
Contributor Author

kellen commented Jan 18, 2024

@unkarjedy Done

@unkarjedy unkarjedy merged commit e2ff680 into JetBrains:master Jan 19, 2024
1 check passed
@unkarjedy
Copy link
Member

Thanks!
The new version should be published soon.

@RustedBones RustedBones mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unkarjedy unkarjedy Awaiting requested review from unkarjedy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellen @unkarjedy