Make encryption buffer size adjustable #99
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow saving memory in cases where we are willing to limit the encryption chunk size.
fortuna
approved these changes
Nov 24, 2020
| } | ||
|
|
||
| // SetSaltGenerator sets the salt generator to be used. Must be called before the first write. | ||
| func (sw *Writer) SetSaltGenerator(saltGenerator SaltGenerator) { | ||
| sw.saltGenerator = saltGenerator | ||
| } | ||
|
|
||
| // SetMaxChunkSize sets the maximum number of bytes to encrypt as a chunk. | ||
| // Defaults to 2^16-1. Smaller values save memory but increase framing overhead. |
There was a problem hiding this comment.
PErhaps mention that it's capped at 2^16-1 as specified in the standard.
|
Keeping for future reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow saving memory in cases where we are willing to limit the
encryption chunk size.