Reduce responsibility of main class

This should make the plugin a ton more testable (though I don't have it in me right now to write tests).

api/src/main/java/com/lishid/openinv/event/OpenPlayerSaveEvent.java

@@ -3,6 +3,7 @@
 import com.google.errorprone.annotations.RestrictedApi;
 import com.lishid.openinv.internal.ISpecialInventory;
 import org.bukkit.entity.Player;
+import org.bukkit.event.HandlerList;
 import org.jetbrains.annotations.ApiStatus;
 import org.jetbrains.annotations.NotNull;
 
@@ -11,6 +12,8 @@
  */
 public class OpenPlayerSaveEvent extends PlayerSaveEvent {
 
+  private static final HandlerList HANDLERS = new HandlerList();
+
   private final ISpecialInventory inventory;
 
   /**
@@ -40,4 +43,14 @@ public class OpenPlayerSaveEvent extends PlayerSaveEvent {
     return inventory;
   }
 
+  @NotNull
+  @Override
+  public HandlerList getHandlers() {
+    return HANDLERS;
+  }
+
+  public static HandlerList getHandlerList() {
+    return HANDLERS;
+  }
+
 }

common/src/main/java/com/lishid/openinv/event/OpenEvents.java

@@ -16,8 +16,8 @@ public static boolean saveCancelled(@NotNull Player player) {
     return call(new PlayerSaveEvent(player));
   }
 
-  public static boolean saveCancelled(@NotNull Player player, @NotNull ISpecialInventory inventory) {
-    return call(new OpenPlayerSaveEvent(player, inventory));
+  public static boolean saveCancelled(@NotNull ISpecialInventory inventory) {
+    return call(new OpenPlayerSaveEvent((Player) inventory.getPlayer(), inventory));
   }
 
   private static <T extends Event & Cancellable> boolean call(T event) {

common/src/main/java/com/lishid/openinv/util/lang/LanguageManager.java

@@ -274,7 +274,7 @@ private void addTranslationFallthrough(@NotNull LangLocation location, @NotNull
         if (sender instanceof Player) {
             return ((Player) sender).getLocale();
         } else {
-            return plugin.getConfig().getString("settings.locale", "en_us");
+            return plugin.getConfig().getString("settings.locale", "en");
         }
     }
 

internal/v1_20_R3/src/main/java/com/lishid/openinv/internal/v1_20_R3/PlayerManager.java

@@ -105,11 +105,6 @@ public PlayerManager(@NotNull Logger logger, @NotNull LanguageManager lang) {
 
     @Override
     public @Nullable Player loadPlayer(@NotNull final OfflinePlayer offline) {
-        // Ensure player has data
-        if (!offline.hasPlayedBefore()) {
-            return null;
-        }
-
         MinecraftServer server = ((CraftServer) Bukkit.getServer()).getServer();
         ServerLevel worldServer = server.getLevel(Level.OVERWORLD);
 

internal/v1_20_R4/src/main/java/com/lishid/openinv/internal/v1_20_R4/PlayerManager.java

@@ -105,11 +105,6 @@ public PlayerManager(@NotNull Logger logger, @NotNull LanguageManager lang) {
 
     @Override
     public @Nullable Player loadPlayer(@NotNull final OfflinePlayer offline) {
-        // Ensure player has data
-        if (!offline.hasPlayedBefore()) {
-            return null;
-        }
-
         MinecraftServer server = ((CraftServer) Bukkit.getServer()).getServer();
         ServerLevel worldServer = server.getLevel(Level.OVERWORLD);
 

internal/v1_21_R1/src/main/java/com/lishid/openinv/internal/v1_21_R1/player/PlayerManager.java

@@ -85,11 +85,6 @@ public PlayerManager(@NotNull Logger logger) {
 
   @Override
   public @Nullable Player loadPlayer(@NotNull final OfflinePlayer offline) {
-    // Ensure player has data
-    if (!offline.hasPlayedBefore()) {
-      return null;
-    }
-
     MinecraftServer server = ((CraftServer) Bukkit.getServer()).getServer();
     ServerLevel worldServer = server.getLevel(Level.OVERWORLD);