Improve PlayerInventory implementation #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix storage contents including other items * Fix regular contents including fake slots * Fix type not being PLAYER * Prefer slot indices to magic constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think for full plugin compatibility we might actually have to reimplement click handling for full control of the click events, which is sad, I was so hoping to avoid that. We might be able to skate by without it by using a separate backing PlayerInventory implementation for the armor-only version. Honestly, the level of compatibility as-is is probably good enough, but I worry. The levels of spaghetti are already getting out of control with all the garbage for placeholder items.
Having typed all that, I think this is probably good enough. Hello and welcome to my rubber ducking process, I do it in the writeup for changes.