Create mock db on docker oracle xe container #39
Conversation
…9535ja9_Create-a-mock-database-with-mock-date-for-dev-purposes_Kinga-Traczyk
| public class User { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) //pod sqlite | ||
| // @GeneratedValue(strategy = GenerationType.AUTO) |
There was a problem hiding this comment.
Don't leave such things in code. Also user id strategy needs to be discussed
| private String email; | ||
|
|
||
|
|
||
| // private String status INT NOT NULL; |
There was a problem hiding this comment.
Remove this block of comments :-)
| public class UserRole { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) //pod sqlite | ||
| // @GeneratedValue(strategy = GenerationType.AUTO) |
There was a problem hiding this comment.
The same situation like before
| @Override | ||
| public UserRole getUserRole() { | ||
| //todo - paskudnie brzydkie | ||
| return userRoleRepository.findAll().stream().filter(role -> role.getName().equals("USER")).findFirst().get(); |
There was a problem hiding this comment.
Streams are sexy but what if role won't be found
|
|
||
| @Override | ||
| public UserRole getUserRole() { | ||
| //todo - paskudnie brzydkie |
There was a problem hiding this comment.
Don't leave comments in Polish :-)
|
|
||
| @Override | ||
| public List<UserDto> getAllUsers() { | ||
| List<User> users =userRepository.findAll(); |
There was a problem hiding this comment.
Use code reformat to avoid places like here =nameOfVariable.
| public UserDto register(RegisterDto registerDto) { | ||
| if(registerDto == null) throw new IllegalArgumentException("Cannot register a null user"); | ||
|
|
||
| //sprawdzenie, czy wszystkie wymagane pola w formularzu zostały wypełnione |
There was a problem hiding this comment.
Again please write comments in English
There was a problem hiding this comment.
Good idea can be seperate application.properties for dev purpose
|
|
Decision: to be closed |
I added scripts to be run on start of the container - creation of user meowhub and all tables on the schema. I put some basic inserts as well.
I changed the image from Oracle Enterprise Edition to Oracle Express Edition - for current development there's no need for all of the advanced options that Enterprise Edtition has to offer, as well as it saves us developers disc space and time that the container needs to start.
It's a first draft, to be improved in the future.