fix: add embedPageTitle selector for adding click hint to the embed p…

…age title roam-unofficial#216
JimmyLv · Apr 30, 2022 · 6deb52c · 6deb52c
1 parent 770bc52
commit 6deb52c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/ts/core/features/vim-mode/hint-view.ts b/src/ts/core/features/vim-mode/hint-view.ts
@@ -51,7 +51,7 @@ Promise.all(HINT_IDS.map(hintCss)).then(cssClasses => {
 export const updateVimHints = (block: HTMLElement) => {
     // button is for reference counts
     const links = block.querySelectorAll(
-        `${Selectors.link}, ${Selectors.externalLink}, ${Selectors.checkbox}, ${Selectors.button}, ${Selectors.blockReference}`
+        `${Selectors.link}, ${Selectors.externalLink}, ${Selectors.embedPageTitle}, ${Selectors.checkbox}, ${Selectors.button}, ${Selectors.blockReference}`
     )
     links.forEach((link, i) => {
         link.classList.add(HINT_CSS_CLASS, hintCssClass(i))

diff --git a/src/ts/core/roam/selectors.ts b/src/ts/core/roam/selectors.ts
@@ -27,7 +27,8 @@ export const Selectors = {
     dailyNotes: '#rm-log-container',
     viewMore: '.roam-log-preview',
     checkbox: '.check-container',
-    externalLink: 'a',
+    externalLink: 'a[target="_blank"]',
+    embedPageTitle: '.rm-embed--page a span.rm-page__title',
     referenceItem: '.rm-reference-item',
     breadcrumbsContainer: '.zoom-mentions-view',
     pageReferenceItem: '.rm-ref-page-view',