Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Use individual relative stat percentage for stat color #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MiquelRForgeFlow
Copy link

@MiquelRForgeFlow MiquelRForgeFlow commented May 11, 2023

Don't use absolute value 255. That value is in fact a false absolute. Only one pokemon reach 255 in a stat (blissey for HP), but maybe someday a new pokemon gets a higher value in another stat.

As it is now, non-evolved pokemons always have red stats, and some yellow. And legendaries will always have green stats. Thus the stat color doesn't say anything new and didn't help much. But my proposal is to change the color of the stat based in a relative way: the bigger stats of a pokemon will be green, the lower red, and around the arithmetic mean yellow. This way, without checking the numerical quantities, we can see a priori which stats are better than others in a specific pokemon.

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the main-stat-percentage branch 2 times, most recently from c4aecdf to 8c81f20 Compare May 12, 2023 15:22
@MiquelRForgeFlow MiquelRForgeFlow changed the title [FIX] Use individual relative stat percentage, not 255 [FIX] Use individual relative stat percentage for stat color May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant