Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new full-moon version v1.1.1 #854

Merged
merged 25 commits into from
Nov 16, 2024
Merged

Update to new full-moon version v1.1.1 #854

merged 25 commits into from
Nov 16, 2024

Conversation

JohnnyMorganz
Copy link
Owner

@JohnnyMorganz JohnnyMorganz commented Jan 27, 2024

Updates StyLua to use the new full-moon release version.

New full-moon version moves syntax configuration to the runtime rather than compile time. We introduce a new option syntax to .stylua.toml to configure this. It defaults to All (i.e., the current behaviour). In cases where different Luau versions are ambiguous (e.g., Luau type assertions v.s goto label syntax), then the syntax option can be overriden. This fixes #407 and its related issues.

syntax = "Lua52"

The other notable change is the separation of LuaJIT from Lua52 into a separate syntax and feature flag.

This update also brings several parser improvements and new Luau syntax features

@clason
Copy link

clason commented Oct 16, 2024

Looks like the full-moon release is actually done now (1.1.0 actually) 🥳

@JohnnyMorganz JohnnyMorganz changed the title Update to new full-moon version v1.1.0 Update to new full-moon version v1.1.1 Nov 16, 2024
Somewhat ugly code, designed to ensure there is snapshot diff.
But, the code can be made nicer in #910
@alerque
Copy link
Contributor

alerque commented Nov 16, 2024

💯

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 70.42254% with 21 lines in your changes missing coverage. Please review.

Project coverage is 96.84%. Comparing base (c6e8619) to head (c8de583).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/formatters/trivia_util.rs 21.73% 18 Missing ⚠️
src/lib.rs 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   97.03%   96.84%   -0.19%     
==========================================
  Files          16       16              
  Lines        5995     6031      +36     
==========================================
+ Hits         5817     5841      +24     
- Misses        178      190      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnnyMorganz JohnnyMorganz marked this pull request as ready for review November 16, 2024 19:16
@JohnnyMorganz JohnnyMorganz merged commit daa6c6e into main Nov 16, 2024
17 checks passed
@JohnnyMorganz JohnnyMorganz deleted the update-full-moon branch November 16, 2024 19:22
@clason
Copy link

clason commented Nov 16, 2024

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lua 5.2 label syntax error when using binary built all features enabled
3 participants