Skip to content

Commit

Permalink
Merge #1493: CI: Remove unnecessary commands from setup joinmarket + …
Browse files Browse the repository at this point in the history
…virtualenv step

3c0b508 Remove unnecessary commands from setup joinmarket + virtualenv step (Kristaps Kaupe)

Pull request description:

  They are run by `install.sh`, no need to run them additionally afterwards.

  If #1475 gets merged, `./jmvenv/bin/pip install -r requirements/testing.txt` can also be removed.

Top commit has no ACKs.

Tree-SHA512: 662cfcfde0ac07f6460a0e59af3af4742eb32aa1adc7846c41b9596d4ae87eb0ac2231d438a8b3aed99a34f73d7e470dab1f7af95ba4a4bdbef35046fd75a56f
  • Loading branch information
kristapsk committed May 13, 2023
2 parents e2a3bd0 + 3c0b508 commit b340cb1
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/unittests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ jobs:
sed -i.bak 's/-e //g' requirements/base.txt
sed -i.bak 's/-e //g' requirements/gui.txt
./install.sh --develop --with-qt
./jmvenv/bin/python -m pip install --upgrade pip
./jmvenv/bin/pip install -r requirements/base.txt
./jmvenv/bin/pip install -r requirements/testing.txt
- name: Lint with flake8
run: ./jmvenv/bin/flake8 -v jmclient jmbase jmbitcoin jmdaemon scripts
Expand Down

0 comments on commit b340cb1

Please sign in to comment.