-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto and user confirmed deletion of book titles #27
Draft
kamauln
wants to merge
72
commits into
JonathanReeve:master
Choose a base branch
from
milanterlunen:deleting-book-titles
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added spell check package for one article
spell check now runs on all articles
replaces articles json file with fixed article texts and returns pd dataframe of articles that cannot be fixed.
the final cell block replaces the initial article json file with one with the fixed text > ie a permanent fix
Auto deletion currently works well - removing ~.25 of text, but user confirmed deletion is still too broad and doesn't capture all possible matches. Current workaround is user just manually deletes remaining book titles.
…etection into fix-pdf-to-text
PDF to Text with page number detection
Hi @kamauln and @gracexu7 ! Thanks so much for all this great work. I'm happy to merge it at some point, provided it's cleaned up. At minimum, you'll want to:
But tests would be good, too, especially if you're changing any functionality. Let me know when you've done this by requesting my review and unmarking it as a draft. Or close this PR and open a different one later, if you prefer. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto deletion currently works well - removing ~.25 of text, but the user confirmed deletion is still too broad and doesn't capture all possible matches. The current workaround is the user just manually deletes the remaining book titles.