📝 Markdown editor #4681
Merged
📝 Markdown editor #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attemka
approved these changes
Aug 21, 2023
packages/atlas/src/components/_inputs/MarkdownEditor/MarkdownEditor.utils.ts
Show resolved
Hide resolved
WRadoslaw
reviewed
Aug 21, 2023
packages/atlas/src/components/_inputs/MarkdownEditor/MarkdownEditor.styles.ts
Outdated
Show resolved
Hide resolved
packages/atlas/src/components/_inputs/MarkdownEditor/MarkdownEditor.styles.ts
Outdated
Show resolved
Hide resolved
thesan
force-pushed
the
feature/markdown-editor
branch
from
16f5c51
to
6a7f0ed
Compare
WRadoslaw
pushed a commit
that referenced
this pull request
Mar 5, 2024
* Add markdown editor * Parse content from and to markdown * Render markdown * WIP * Add format buttons * Flatten text nodes * Style the toolbar * Switch to pure markdown * Add basic markdown "shortcuts" * Improve inline formats wrapping * Add link and separator buttons * Remove unused dependencies * Support undo/redo via keyboard shortcuts * Add a placeholder * Add a max length * Small refactor * Clean unused code * Pre-select the url after adding a link * Add common keyboard shortcuts * Re-use Atlas styles
WRadoslaw
pushed a commit
that referenced
this pull request
Mar 14, 2024
* Add markdown editor * Parse content from and to markdown * Render markdown * WIP * Add format buttons * Flatten text nodes * Style the toolbar * Switch to pure markdown * Add basic markdown "shortcuts" * Improve inline formats wrapping * Add link and separator buttons * Remove unused dependencies * Support undo/redo via keyboard shortcuts * Add a placeholder * Add a max length * Small refactor * Clean unused code * Pre-select the url after adding a link * Add common keyboard shortcuts * Re-use Atlas styles
WRadoslaw
pushed a commit
that referenced
this pull request
Mar 14, 2024
* Add markdown editor * Parse content from and to markdown * Render markdown * WIP * Add format buttons * Flatten text nodes * Style the toolbar * Switch to pure markdown * Add basic markdown "shortcuts" * Improve inline formats wrapping * Add link and separator buttons * Remove unused dependencies * Support undo/redo via keyboard shortcuts * Add a placeholder * Add a max length * Small refactor * Clean unused code * Pre-select the url after adding a link * Add common keyboard shortcuts * Re-use Atlas styles
WRadoslaw
pushed a commit
to WRadoslaw/atlas
that referenced
this pull request
Apr 22, 2024
* Add markdown editor * Parse content from and to markdown * Render markdown * WIP * Add format buttons * Flatten text nodes * Style the toolbar * Switch to pure markdown * Add basic markdown "shortcuts" * Improve inline formats wrapping * Add link and separator buttons * Remove unused dependencies * Support undo/redo via keyboard shortcuts * Add a placeholder * Add a max length * Small refactor * Clean unused code * Pre-select the url after adding a link * Add common keyboard shortcuts * Re-use Atlas styles
WRadoslaw
pushed a commit
to WRadoslaw/atlas
that referenced
this pull request
Apr 22, 2024
* Add markdown editor * Parse content from and to markdown * Render markdown * WIP * Add format buttons * Flatten text nodes * Style the toolbar * Switch to pure markdown * Add basic markdown "shortcuts" * Improve inline formats wrapping * Add link and separator buttons * Remove unused dependencies * Support undo/redo via keyboard shortcuts * Add a placeholder * Add a max length * Small refactor * Clean unused code * Pre-select the url after adding a link * Add common keyboard shortcuts * Re-use Atlas styles
WRadoslaw
pushed a commit
to Joystream/gleev
that referenced
this pull request
Apr 22, 2024
* Add markdown editor * Parse content from and to markdown * Render markdown * WIP * Add format buttons * Flatten text nodes * Style the toolbar * Switch to pure markdown * Add basic markdown "shortcuts" * Improve inline formats wrapping * Add link and separator buttons * Remove unused dependencies * Support undo/redo via keyboard shortcuts * Add a placeholder * Add a max length * Small refactor * Clean unused code * Pre-select the url after adding a link * Add common keyboard shortcuts * Re-use Atlas styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly I didn't expect writing so much code for this feature. When I picked Slate I had misunderstood #3403, I thought it was about adding a rich text editor which would save and load markdown just like in Pioneer. Once I realized it was something similar to the GH editor I checked a few alternatives but they weren't very customizable so I kept Slate. But I might have been biased since I really didn't want to restart from scratch several days in.
Otoh it should make adding more feature later on easier if needed.
https://atlas-storybook-git-fork-thesan-feature-markdo-1572b7-joystream.vercel.app/?path=/story/inputs-markdowneditor--markdown-editor