-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💸 Buy token on sale modal #4728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk regarding hardcoded data, let me know your thoughts
packages/atlas/src/components/_crt/BuySaleTokenModal/BuySaleTokenModal.tsx
Outdated
Show resolved
Hide resolved
noContentPadding={activeStep === BUY_SALE_TOKEN_STEPS.terms} | ||
confetti={activeStep === BUY_SALE_TOKEN_STEPS.success && smMatch} | ||
> | ||
{activeStep === BUY_SALE_TOKEN_STEPS.form && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ofc we can do like that, but I think it would be better to keep the unified code style and use switch(activeStep)
here. wdyt?
packages/atlas/src/components/_crt/BuySaleTokenModal/steps/BuySaleTokenForm.tsx
Outdated
Show resolved
Hide resolved
packages/atlas/src/components/_crt/BuySaleTokenModal/steps/BuySaleTokenSuccess.tsx
Show resolved
Hide resolved
* Main modal * Form step * Terms step - initial * Terms step - chart * Storybook * Add checkbox for terms * Success modal * Remove unnecessary component * CR fixes * CR fixes v2
* Main modal * Form step * Terms step - initial * Terms step - chart * Storybook * Add checkbox for terms * Success modal * Remove unnecessary component * CR fixes * CR fixes v2
* Main modal * Form step * Terms step - initial * Terms step - chart * Storybook * Add checkbox for terms * Success modal * Remove unnecessary component * CR fixes * CR fixes v2
* Main modal * Form step * Terms step - initial * Terms step - chart * Storybook * Add checkbox for terms * Success modal * Remove unnecessary component * CR fixes * CR fixes v2
* Main modal * Form step * Terms step - initial * Terms step - chart * Storybook * Add checkbox for terms * Success modal * Remove unnecessary component * CR fixes * CR fixes v2
* Main modal * Form step * Terms step - initial * Terms step - chart * Storybook * Add checkbox for terms * Success modal * Remove unnecessary component * CR fixes * CR fixes v2
#3830
#3833