Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💸 Buy token on sale modal #4728

Merged
merged 11 commits into from
Aug 28, 2023
Merged

Conversation

WRadoslaw
Copy link
Contributor

Copy link
Contributor

@attemka attemka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk regarding hardcoded data, let me know your thoughts

noContentPadding={activeStep === BUY_SALE_TOKEN_STEPS.terms}
confetti={activeStep === BUY_SALE_TOKEN_STEPS.success && smMatch}
>
{activeStep === BUY_SALE_TOKEN_STEPS.form && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ofc we can do like that, but I think it would be better to keep the unified code style and use switch(activeStep) here. wdyt?

@attemka attemka merged commit dabfba3 into Joystream:crt Aug 28, 2023
1 check passed
WRadoslaw added a commit that referenced this pull request Mar 5, 2024
* Main modal

* Form step

* Terms step - initial

* Terms step - chart

* Storybook

* Add checkbox for terms

* Success modal

* Remove unnecessary component

* CR fixes

* CR fixes v2
WRadoslaw added a commit that referenced this pull request Mar 14, 2024
* Main modal

* Form step

* Terms step - initial

* Terms step - chart

* Storybook

* Add checkbox for terms

* Success modal

* Remove unnecessary component

* CR fixes

* CR fixes v2
WRadoslaw added a commit that referenced this pull request Mar 14, 2024
* Main modal

* Form step

* Terms step - initial

* Terms step - chart

* Storybook

* Add checkbox for terms

* Success modal

* Remove unnecessary component

* CR fixes

* CR fixes v2
WRadoslaw added a commit to WRadoslaw/atlas that referenced this pull request Apr 22, 2024
* Main modal

* Form step

* Terms step - initial

* Terms step - chart

* Storybook

* Add checkbox for terms

* Success modal

* Remove unnecessary component

* CR fixes

* CR fixes v2
WRadoslaw added a commit to WRadoslaw/atlas that referenced this pull request Apr 22, 2024
* Main modal

* Form step

* Terms step - initial

* Terms step - chart

* Storybook

* Add checkbox for terms

* Success modal

* Remove unnecessary component

* CR fixes

* CR fixes v2
WRadoslaw added a commit to Joystream/gleev that referenced this pull request Apr 22, 2024
* Main modal

* Form step

* Terms step - initial

* Terms step - chart

* Storybook

* Add checkbox for terms

* Success modal

* Remove unnecessary component

* CR fixes

* CR fixes v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants