Fix ambig with configured frule created by non_differentiable rule #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
I can't get it to precompile? PS C:\Users\arno\Desktop\SciML\Surrogates.jl> julia
_
_ _ _(_)_ | Documentation: https://docs.julialang.org
(_) | (_) (_) |
_ _ _| |_ __ _ | Type "?" for help, "]?" for Pkg help.
| | | | | | |/ _` | |
| | |_| | | | (_| | | Version 1.10.0 (2023-12-25)
_/ |\__'_|_|_|\__'_| | Official https://julialang.org/ release
|__/ |
julia> using TestEnv; using Pkg; Pkg.activate("."); TestEnv.activate()
Activating project at `C:\Users\arno\Desktop\SciML\Surrogates.jl`
┌ Warning: The project dependencies or compat requirements have changed since the manifest was last resolved.
│ It is recommended to `Pkg.resolve()` or consider `Pkg.update()` if necessary.
└ @ Pkg.API C:\Users\arno\.julia\juliaup\julia-1.10.0+0.x64.w64.mingw32\share\julia\stdlib\v1.10\Pkg\src\API.jl:1800
"C:\\Users\\arno\\AppData\\Local\\Temp\\jl_g3MQgu\\Project.toml"
(jl_g3MQgu) pkg> add https://github.com/JuliaDiff/ChainRulesCore.jl/tree/ox/non_diff_ambig
Updating git-repo `https://github.com/JuliaDiff/ChainRulesCore.jl`
Resolving package versions...
Updating `C:\Users\arno\AppData\Local\Temp\jl_g3MQgu\Project.toml`
[d360d2e6] ~ ChainRulesCore v1.19.0 ⇒ v1.19.1 `https://github.com/JuliaDiff/ChainRulesCore.jl#ox/non_diff_ambig`
Updating `C:\Users\arno\AppData\Local\Temp\jl_g3MQgu\Manifest.toml`
[d360d2e6] ~ ChainRulesCore v1.19.0 ⇒ v1.19.1 `https://github.com/JuliaDiff/ChainRulesCore.jl#ox/non_diff_ambig`
Precompiling project...
✗ Optimisers
✗ Distributions → DistributionsChainRulesCoreExt
✗ MLUtils
✗ Tracker
✗ Tracker → TrackerPDMatsExt
✗ Zygote → ZygoteTrackerExt
✗ Surrogates
✗ Flux
0 dependencies successfully precompiled in 24 seconds. 149 already precompiled.
8 dependencies errored.
For a report of the errors see `julia> err`. To retry use `pkg> precompile`
(jl_g3MQgu) pkg> precompile
Precompiling project...
✗ Optimisers
✗ Distributions → DistributionsChainRulesCoreExt
✗ MLUtils
✗ Tracker
✗ Tracker → TrackerPDMatsExt
✗ Zygote → ZygoteTrackerExt
✗ Surrogates
✗ Flux
0 dependencies successfully precompiled in 24 seconds. 149 already precompiled.
ERROR: The following 3 direct dependencies failed to precompile:
Surrogates [6fc51010-71bc-11e9-0e15-a3fcc6593c49]
Failed to precompile Surrogates [6fc51010-71bc-11e9-0e15-a3fcc6593c49] to "C:\\Users\\arno\\.julia\\compiled\\v1.10\\Surrogates\\jl_41FF.tmp".
ERROR: LoadError: UndefVarError: `RuleConfig` not defined
Stacktrace:
[1] top-level scope
@ C:\Users\arno\.julia\packages\Distributions\WFzvT\ext\DistributionsChainRulesCoreExt\utils.jl:383
[2] include(mod::Module, _path::String)
@ Base .\Base.jl:495
[3] include(x::String)
@ DistributionsChainRulesCoreExt C:\Users\arno\.julia\packages\Distributions\WFzvT\ext\DistributionsChainRulesCoreExt\DistributionsChainRulesCoreExt.jl:1
[4] top-level scope
@ C:\Users\arno\.julia\packages\Distributions\WFzvT\ext\DistributionsChainRulesCoreExt\DistributionsChainRulesCoreExt.jl:8
[5] include
@ Base .\Base.jl:495 [inlined]
[6] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::String)
@ Base .\loading.jl:2216
[7] top-level scope
@ stdin:3
in expression starting at C:\Users\arno\.julia\packages\Distributions\WFzvT\ext\DistributionsChainRulesCoreExt\utils.jl:1
in expression starting at C:\Users\arno\.julia\packages\Distributions\WFzvT\ext\DistributionsChainRulesCoreExt\DistributionsChainRulesCoreExt.jl:1
in expression starting at stdin:3
┌ Error: Error during loading of extension DistributionsChainRulesCoreExt of Distributions, use `Base.retry_load_extensions()` to retry.
│ exception =
│ 1-element ExceptionStack:
│ Failed to precompile DistributionsChainRulesCoreExt [6db1f127-056a-568b-bd49-ae61d42389fa] to "C:\\Users\\arno\\.julia\\compiled\\v1.10\\DistributionsChainRulesCoreExt\\jl_47CF.tmp".
│ Stacktrace:
│ [1] error(s::String)
│ @ Base .\error.jl:35
│ [2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, keep_loaded_modules::Bool)
│ @ Base .\loading.jl:2462
│ [3] compilecache
│ @ Base .\loading.jl:2334 [inlined]
│ [4] (::Base.var"#968#969"{Base.PkgId})()
│ @ Base .\loading.jl:1968
│ [5] mkpidlock(f::Base.var"#968#969"{Base.PkgId}, at::String, pid::Int32; kwopts::@Kwargs{stale_age::Int64, wait::Bool})
│ @ FileWatching.Pidfile C:\Users\arno\.julia\juliaup\julia-1.10.0+0.x64.w64.mingw32\share\julia\stdlib\v1.10\FileWatching\src\pidfile.jl:93
│ [6] #mkpidlock#6
│ @ FileWatching.Pidfile C:\Users\arno\.julia\juliaup\julia-1.10.0+0.x64.w64.mingw32\share\julia\stdlib\v1.10\FileWatching\src\pidfile.jl:88 [inlined]
│ [7] trymkpidlock(::Function, ::Vararg{Any}; kwargs::@Kwargs{stale_age::Int64})
│ @ FileWatching.Pidfile C:\Users\arno\.julia\juliaup\julia-1.10.0+0.x64.w64.mingw32\share\julia\stdlib\v1.10\FileWatching\src\pidfile.jl:111
│ [8] #invokelatest#2
│ @ Base .\essentials.jl:889 [inlined]
│ [9] invokelatest
│ @ Base .\essentials.jl:884 [inlined]
│ [10] maybe_cachefile_lock(f::Base.var"#968#969"{Base.PkgId}, pkg::Base.PkgId, srcpath::String; stale_age::Int64)
│ @ Base .\loading.jl:2977
│ [11] maybe_cachefile_lock
│ @ Base .\loading.jl:2974 [inlined]
│ [12] _require(pkg::Base.PkgId, env::Nothing)
│ @ Base .\loading.jl:1964
│ [13] __require_prelocked(uuidkey::Base.PkgId, env::Nothing)
│ @ Base .\loading.jl:1806
│ [14] #invoke_in_world#3
│ @ Base .\essentials.jl:921 [inlined]
│ [15] invoke_in_world
│ @ Base .\essentials.jl:918 [inlined]
│ [16] _require_prelocked
│ @ Base .\loading.jl:1797 [inlined]
│ [17] _require_prelocked
│ @ Base .\loading.jl:1796 [inlined]
│ [18] run_extension_callbacks(extid::Base.ExtensionId)
│ @ Base .\loading.jl:1289
│ [19] run_extension_callbacks(pkgid::Base.PkgId)
│ @ Base .\loading.jl:1324
│ [20] run_package_callbacks(modkey::Base.PkgId)
│ @ Base .\loading.jl:1158
│ [21] _tryrequire_from_serialized(modkey::Base.PkgId, path::String, ocachepath::String, sourcepath::String, depmods::Vector{Any})
│ @ Base .\loading.jl:1481
│ [22] _require_search_from_serialized(pkg::Base.PkgId, sourcepath::String, build_id::UInt128)
│ @ Base .\loading.jl:1568
│ [23] _require(pkg::Base.PkgId, env::String)
│ @ Base .\loading.jl:1932
│ [24] __require_prelocked(uuidkey::Base.PkgId, env::String)
│ @ Base .\loading.jl:1806
│ [25] #invoke_in_world#3
│ @ Base .\essentials.jl:921 [inlined]
│ [26] invoke_in_world
│ @ Base .\essentials.jl:918 [inlined]
│ [27] _require_prelocked(uuidkey::Base.PkgId, env::String)
│ @ Base .\loading.jl:1797
│ [28] macro expansion
│ @ Base .\loading.jl:1784 [inlined]
│ [29] macro expansion
│ @ Base .\lock.jl:267 [inlined]
│ [30] __require(into::Module, mod::Symbol)
│ @ Base .\loading.jl:1747
│ [31] #invoke_in_world#3
│ @ Base .\essentials.jl:921 [inlined]
│ [32] invoke_in_world
│ @ Base .\essentials.jl:918 [inlined]
│ [33] require(into::Module, mod::Symbol)
│ @ Base .\loading.jl:1740
│ [34] include(mod::Module, _path::String)
│ @ Base .\Base.jl:495
│ [35] include(x::String)
│ @ Surrogates C:\Users\arno\Desktop\SciML\Surrogates.jl\src\Surrogates.jl:1
│ [36] top-level scope
│ @ C:\Users\arno\Desktop\SciML\Surrogates.jl\src\Surrogates.jl:7
│ [37] include
│ @ Base .\Base.jl:495 [inlined]
│ [38] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
│ @ Base .\loading.jl:2216
│ [39] top-level scope
│ @ stdin:3
│ [40] eval
│ @ Core .\boot.jl:385 [inlined]
│ [41] include_string(mapexpr::typeof(identity), mod::Module, code::String, filename::String)
│ @ Base .\loading.jl:2070
│ [42] include_string
│ @ Base .\loading.jl:2080 [inlined]
│ [43] exec_options(opts::Base.JLOptions)
│ @ Base .\client.jl:316
│ [44] _start()
│ @ Base .\client.jl:552
└ @ Base loading.jl:1295
ERROR: LoadError: UndefVarError: `RuleConfig` not defined
Stacktrace:
[1] top-level scope
@ C:\Users\arno\Desktop\SciML\Surrogates.jl\src\Radials.jl:383
[2] include(mod::Module, _path::String)
@ Base .\Base.jl:495
[3] include(x::String)
@ Surrogates C:\Users\arno\Desktop\SciML\Surrogates.jl\src\Surrogates.jl:1
[4] top-level scope
@ C:\Users\arno\Desktop\SciML\Surrogates.jl\src\Surrogates.jl:7
[5] include
@ Base .\Base.jl:495 [inlined]
[6] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
@ Base .\loading.jl:2216
[7] top-level scope
@ stdin:3
in expression starting at C:\Users\arno\Desktop\SciML\Surrogates.jl\src\Radials.jl:123
in expression starting at C:\Users\arno\Desktop\SciML\Surrogates.jl\src\Surrogates.jl:1
in expression starting at stdin:3
Flux [587475ba-b771-5e3f-ad9e-33799f191a9c]
Failed to precompile Flux [587475ba-b771-5e3f-ad9e-33799f191a9c] to "C:\\Users\\arno\\.julia\\compiled\\v1.10\\Flux\\jl_4231.tmp".
ERROR: LoadError: UndefVarError: `RuleConfig` not defined
Stacktrace:
[1] top-level scope
@ C:\Users\arno\.julia\packages\MLUtils\LmmaQ\src\utils.jl:383
[2] include(mod::Module, _path::String)
@ Base .\Base.jl:495
[3] include(x::String)
@ MLUtils C:\Users\arno\.julia\packages\MLUtils\LmmaQ\src\MLUtils.jl:1
[4] top-level scope
@ C:\Users\arno\.julia\packages\MLUtils\LmmaQ\src\MLUtils.jl:65
[5] include
@ Base .\Base.jl:495 [inlined]
[6] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::String)
@ Base .\loading.jl:2216
[7] top-level scope
@ stdin:3
in expression starting at C:\Users\arno\.julia\packages\MLUtils\LmmaQ\src\utils.jl:237
in expression starting at C:\Users\arno\.julia\packages\MLUtils\LmmaQ\src\MLUtils.jl:1
in expression starting at stdin:3
ERROR: LoadError: Failed to precompile MLUtils [f1d291b0-491e-4a28-83b9-f70985020b54] to "C:\\Users\\arno\\.julia\\compiled\\v1.10\\MLUtils\\jl_482D.tmp".
Stacktrace:
[1] error(s::String)
@ Base .\error.jl:35
[2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, keep_loaded_modules::Bool)
@ Base .\loading.jl:2462
[3] compilecache
@ Base .\loading.jl:2334 [inlined]
[4] (::Base.var"#968#969"{Base.PkgId})()
@ Base .\loading.jl:1968
[5] mkpidlock(f::Base.var"#968#969"{Base.PkgId}, at::String, pid::Int32; kwopts::@Kwargs{stale_age::Int64, wait::Bool})
@ FileWatching.Pidfile C:\Users\arno\.julia\juliaup\julia-1.10.0+0.x64.w64.mingw32\share\julia\stdlib\v1.10\FileWatching\src\pidfile.jl:93
[6] #mkpidlock#6
@ FileWatching.Pidfile C:\Users\arno\.julia\juliaup\julia-1.10.0+0.x64.w64.mingw32\share\julia\stdlib\v1.10\FileWatching\src\pidfile.jl:88 [inlined]
[7] trymkpidlock(::Function, ::Vararg{Any}; kwargs::@Kwargs{stale_age::Int64})
@ FileWatching.Pidfile C:\Users\arno\.julia\juliaup\julia-1.10.0+0.x64.w64.mingw32\share\julia\stdlib\v1.10\FileWatching\src\pidfile.jl:111
[8] #invokelatest#2
@ Base .\essentials.jl:889 [inlined]
[9] invokelatest
@ Base .\essentials.jl:884 [inlined]
[10] maybe_cachefile_lock(f::Base.var"#968#969"{Base.PkgId}, pkg::Base.PkgId, srcpath::String; stale_age::Int64)
@ Base .\loading.jl:2977
[11] maybe_cachefile_lock
@ Base .\loading.jl:2974 [inlined]
[12] _require(pkg::Base.PkgId, env::String)
@ Base .\loading.jl:1964
[13] __require_prelocked(uuidkey::Base.PkgId, env::String)
@ Base .\loading.jl:1806
[14] #invoke_in_world#3
@ Base .\essentials.jl:921 [inlined]
[15] invoke_in_world
@ Base .\essentials.jl:918 [inlined]
[16] _require_prelocked(uuidkey::Base.PkgId, env::String)
@ Base .\loading.jl:1797
[17] macro expansion
@ Base .\loading.jl:1784 [inlined]
[18] macro expansion
@ Base .\lock.jl:267 [inlined]
[19] __require(into::Module, mod::Symbol)
@ Base .\loading.jl:1747
[20] #invoke_in_world#3
@ Base .\essentials.jl:921 [inlined]
[21] invoke_in_world
@ Base .\essentials.jl:918 [inlined]
[22] require(into::Module, mod::Symbol)
@ Base .\loading.jl:1740
[23] include
@ Base .\Base.jl:495 [inlined]
[24] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
@ Base .\loading.jl:2216
[25] top-level scope
@ stdin:3
in expression starting at C:\Users\arno\.julia\packages\Flux\PpGmk\src\Flux.jl:1
in expression starting at stdin:3
Tracker [9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c]
Failed to precompile Tracker [9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c] to "C:\\Users\\arno\\.julia\\compiled\\v1.10\\Tracker\\jl_599.tmp".
ERROR: LoadError: UndefVarError: `RuleConfig` not defined
Stacktrace:
[1] top-level scope
@ C:\Users\arno\.julia\packages\Optimisers\NnLqJ\src\destructure.jl:383
[2] include(mod::Module, _path::String)
@ Base .\Base.jl:495
[3] include(x::String)
@ Optimisers C:\Users\arno\.julia\packages\Optimisers\NnLqJ\src\Optimisers.jl:1
[4] top-level scope
@ C:\Users\arno\.julia\packages\Optimisers\NnLqJ\src\Optimisers.jl:11
[5] include
@ Base .\Base.jl:495 [inlined]
[6] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::String)
@ Base .\loading.jl:2216
[7] top-level scope
@ stdin:3
in expression starting at C:\Users\arno\.julia\packages\Optimisers\NnLqJ\src\destructure.jl:140
in expression starting at C:\Users\arno\.julia\packages\Optimisers\NnLqJ\src\Optimisers.jl:1
in expression starting at stdin:3
ERROR: LoadError: Failed to precompile Optimisers [3bd65402-5787-11e9-1adc-39752487f4e2] to "C:\\Users\\arno\\.julia\\compiled\\v1.10\\Optimisers\\jl_11FA.tmp".
Stacktrace:
[1] error(s::String)
@ Base .\error.jl:35
[2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, keep_loaded_modules::Bool)
@ Base .\loading.jl:2462
[3] compilecache
@ Base .\loading.jl:2334 [inlined]
[4] (::Base.var"#968#969"{Base.PkgId})()
@ Base .\loading.jl:1968
[5] mkpidlock(f::Base.var"#968#969"{Base.PkgId}, at::String, pid::Int32; kwopts::@Kwargs{stale_age::Int64, wait::Bool})
@ FileWatching.Pidfile C:\Users\arno\.julia\juliaup\julia-1.10.0+0.x64.w64.mingw32\share\julia\stdlib\v1.10\FileWatching\src\pidfile.jl:93
[6] #mkpidlock#6
@ FileWatching.Pidfile C:\Users\arno\.julia\juliaup\julia-1.10.0+0.x64.w64.mingw32\share\julia\stdlib\v1.10\FileWatching\src\pidfile.jl:88 [inlined]
[7] trymkpidlock(::Function, ::Vararg{Any}; kwargs::@Kwargs{stale_age::Int64})
@ FileWatching.Pidfile C:\Users\arno\.julia\juliaup\julia-1.10.0+0.x64.w64.mingw32\share\julia\stdlib\v1.10\FileWatching\src\pidfile.jl:111
[8] #invokelatest#2
@ Base .\essentials.jl:889 [inlined]
[9] invokelatest
@ Base .\essentials.jl:884 [inlined]
[10] maybe_cachefile_lock(f::Base.var"#968#969"{Base.PkgId}, pkg::Base.PkgId, srcpath::String; stale_age::Int64)
@ Base .\loading.jl:2977
[11] maybe_cachefile_lock
@ Base .\loading.jl:2974 [inlined]
[12] _require(pkg::Base.PkgId, env::String)
@ Base .\loading.jl:1964
[13] __require_prelocked(uuidkey::Base.PkgId, env::String)
@ Base .\loading.jl:1806
[14] #invoke_in_world#3
@ Base .\essentials.jl:921 [inlined]
[15] invoke_in_world
@ Base .\essentials.jl:918 [inlined]
[16] _require_prelocked(uuidkey::Base.PkgId, env::String)
@ Base .\loading.jl:1797
[17] macro expansion
@ Base .\loading.jl:1784 [inlined]
[18] macro expansion
@ Base .\lock.jl:267 [inlined]
[19] __require(into::Module, mod::Symbol)
@ Base .\loading.jl:1747
[20] #invoke_in_world#3
@ Base .\essentials.jl:921 [inlined]
[21] invoke_in_world
@ Base .\essentials.jl:918 [inlined]
[22] require(into::Module, mod::Symbol)
@ Base .\loading.jl:1740
[23] include(mod::Module, _path::String)
@ Base .\Base.jl:495
[24] include(x::String)
@ Tracker C:\Users\arno\.julia\packages\Tracker\5lAQO\src\Tracker.jl:1
[25] top-level scope
@ C:\Users\arno\.julia\packages\Tracker\5lAQO\src\Tracker.jl:76
[26] include
@ Base .\Base.jl:495 [inlined]
[27] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
@ Base .\loading.jl:2216
[28] top-level scope
@ stdin:3
in expression starting at C:\Users\arno\.julia\packages\Tracker\5lAQO\src\back.jl:183
in expression starting at C:\Users\arno\.julia\packages\Tracker\5lAQO\src\Tracker.jl:1
in expression starting at stdin:3 |
|
I think I have misunderstood the problem. |
…rg so no ambig with ruleconfig first arg
oxinabox
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
=======================================
Coverage 93.79% 93.79%
=======================================
Files 14 14
Lines 886 886
=======================================
Hits 831 831
Misses 55 55 ☔ View full report in Codecov by Sentry. |
|
CI failures in 1.10 are fixed by #645 |
|
@ArnoStrouwen can you take another look? |
ArnoStrouwen
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
No ambiguity found anymore in Surrogates.jl with this branch.
PS C:\Users\arno\Desktop\SciML\Surrogates.jl> julia --depwarn=yes
_
_ _ _(_)_ | Documentation: https://docs.julialang.org
(_) | (_) (_) |
_ _ _| |_ __ _ | Type "?" for help, "]?" for Pkg help.
| | | | | | |/ _` | |
| | |_| | | | (_| | | Version 1.10.0 (2023-12-25)
_/ |\__'_|_|_|\__'_| | Official https://julialang.org/ release
|__/ |
julia> using TestEnv; using Pkg; Pkg.activate("."); TestEnv.activate()
Activating project at `C:\Users\arno\Desktop\SciML\Surrogates.jl`
┌ Warning: The project dependencies or compat requirements have changed since the manifest was last resolved.
│ It is recommended to `Pkg.resolve()` or consider `Pkg.update()` if necessary.
└ @ Pkg.API C:\Users\arno\.julia\juliaup\julia-1.10.0+0.x64.w64.mingw32\share\julia\stdlib\v1.10\Pkg\src\API.jl:1800
Precompiling project...
1 dependency successfully precompiled in 5 seconds. 109 already precompiled.
"C:\\Users\\arno\\AppData\\Local\\Temp\\jl_cFu81H\\Project.toml"
(jl_cFu81H) pkg> add https://github.com/JuliaDiff/ChainRulesCore.jl/tree/ox/non_diff_ambig
Updating git-repo `https://github.com/JuliaDiff/ChainRulesCore.jl`
Resolving package versions...
Updating `C:\Users\arno\AppData\Local\Temp\jl_cFu81H\Project.toml`
[d360d2e6] ~ ChainRulesCore v1.19.0 ⇒ v1.19.1 `https://github.com/JuliaDiff/ChainRulesCore.jl#ox/non_diff_ambig`
Updating `C:\Users\arno\AppData\Local\Temp\jl_cFu81H\Manifest.toml`
[d360d2e6] ~ ChainRulesCore v1.19.0 ⇒ v1.19.1 `https://github.com/JuliaDiff/ChainRulesCore.jl#ox/non_diff_ambig`
Precompiling project...
23 dependencies successfully precompiled in 27 seconds. 134 already precompiled.
julia> cd("./test")
julia> using Test
julia> using SafeTestsets
julia> using Pkg
julia> @safetestset "Quality Assurance" begin include("qa.jl") end
Test Summary: | Pass Total Time
Quality Assurance | 10 10 1m11.9s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am surprised we didn't run into this earlier.
I guess because noone has been using forward mode that seriously.
(in particular right now Diffractor doesn't support kwargs right: JuliaDiff/Diffractor.jl#244)
Or maybe something changed in 1.10 (since JuliaDiff/ChainRules.jl#765 also showed up)
Fixes SciML/Surrogates.jl#462 (comment)
@ArnoStrouwen can you confirm this fixes your problem, and if so approve this PR?