WIP: handle zero_tangent in presence of cyclic structures (v1) #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
format self-refrential (squash me into prev) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| is_defined_mask = Expr(:tuple, map(fieldnames(primal)) do fname | ||
| :(isdefined(primal, $(QuoteNode(fname)))) | ||
| end...) | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Comment on lines
+164
to
+169
| $( | ||
| map(fieldnames(primal), zfield_exprs) do fname, fval_expr | ||
| :(setproperty!(tangent, $(QuoteNode(fname)), $fval_expr)) | ||
| end... | ||
| ) | ||
| return tangent |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| $( | |
| map(fieldnames(primal), zfield_exprs) do fname, fval_expr | |
| :(setproperty!(tangent, $(QuoteNode(fname)), $fval_expr)) | |
| end... | |
| ) | |
| return tangent | |
| $(map(fieldnames(primal), zfield_exprs) do fname, fval_expr | |
| :(setproperty!(tangent, $(QuoteNode(fname)), $fval_expr)) | |
| end...) | |
| return tangent |
| else | ||
| :($Tangent{$primal}($(Expr(:parameters, zfield_exprs...)))) | ||
| :($Tangent{$primal}($(Expr(:parameters, Expr.(:kw, fieldnames(primal), zfield_exprs)...)))) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| :($Tangent{$primal}($(Expr(:parameters, Expr.(:kw, fieldnames(primal), zfield_exprs)...)))) | |
| :($Tangent{$primal}( | |
| $(Expr(:parameters, Expr.(:kw, fieldnames(primal), zfield_exprs)...)) | |
| )) |
| # The following will fall back to `Any` if it is hard to infer | ||
| function guess_zero_tangent_type(::Type{T}) where {T} | ||
| return Core.Compiler.return_type(zero_tangent, Tuple{T}) | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| end | |
| end |
| global function _MutableTangent(::Val{P}, is_defined_mask, tangent_types) where {P} | ||
| backing_vals = map(is_defined_mask, tangent_types) do is_def, tangent_type | ||
| ref = if !is_def | ||
| Ref{Union{ZeroTangent, tangent_type}} # allow a Zero which will be used for uninitialized values |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| Ref{Union{ZeroTangent, tangent_type}} # allow a Zero which will be used for uninitialized values | |
| Ref{Union{ZeroTangent,tangent_type}} # allow a Zero which will be used for uninitialized values |
| return ref() # undefined, but it will be filled later | ||
| end | ||
| backing = NamedTuple{fieldnames(P)}(backing_vals) | ||
| return new{P, typeof(backing)}(backing) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| return new{P, typeof(backing)}(backing) | |
| return new{P,typeof(backing)}(backing) |
Comment on lines
109
to
110
|
|
||
| function MutableTangent{P}(fvals) where P |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function MutableTangent{P}(fvals) where P | |
| function MutableTangent{P}(fvals) where {P} |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ox/mutabletangent #654 +/- ##
=====================================================
+ Coverage 94.15% 94.34% +0.18%
=====================================================
Files 15 15
Lines 976 991 +15
=====================================================
+ Hits 919 935 +16
+ Misses 57 56 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 25, 2024
oxinabox
force-pushed
the
ox/mutabletangent
branch
from
f9ade6e to
95e63d0
Compare
|
Closing in favor of #655 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #626
this was my first take at it.
I do not like it because it depends on
Core.Compiler.return_typewhich is unreliable for getting tight types and in real cases I have tried falls back to returningAny.and this code adds a lot of complexity and still doesn't catch everything.