Bools have no tangent #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 93.62% 93.54% -0.09%
==========================================
Files 15 15
Lines 989 991 +2
==========================================
+ Hits 926 927 +1
- Misses 63 64 +1 ☔ View full report in Codecov by Sentry. |
willtebbutt
reviewed
Feb 28, 2024
| @@ -178,6 +179,8 @@ end | |||
|
|
|||
| # Sad heauristic methods we need because of unassigned values | |||
| guess_zero_tangent_type(::Type{T}) where {T<:Number} = T | |||
| guess_zero_tangent_type(::Type{Bool}) = NoTangent() | |||
There was a problem hiding this comment.
Should this not just be NoTangent?
|
Should I go wider and do all Integers |
|
I think that would be a good idea if you target the concrete subtypes, rather than the abstract type |
|
merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this improves type stability of Diffractor's forwards mode since if you have code that is like
then the first branch would get a tangent of
NoTangent()due to the fact that we have@non_differentiable Base.:>(::Any, ::Any).But the second would (without this PR) get a tangent of
false.I am tempted to make this Integers.
But seemed starting conservative with Bool might be better
@willtebbutt you have thought about this a lot, what do you think?