-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monkey patch Test.scrub_backtrace #287
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
==========================================
- Coverage 93.65% 93.50% -0.16%
==========================================
Files 12 12
Lines 347 354 +7
==========================================
+ Hits 325 331 +6
- Misses 22 23 +1
☔ View full report in Codecov by Sentry. |
I tried adding a Nor did Suppressor.jl did get it though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested locally on some of my own code, and seems to work fine. Play nicely with Revise etc (as you would expect), so seems to be fine.
Problem is
the
@test
macro is that it scrubs backtraces to remove stuff from deeper down the stack than the location of the macro, and sincetest_rrule
etc use those macros directly the back trace no longer includes the call site in the users tests.Simple solution is to just stop scrubbing backtraces entirely.
If people like this we could follow up with something more sophisticated.
But lets have that as a seperate PR
This does mean whenever tests are run this warning will show.
Could surpress that though.