-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added helpful failure massages for tests #288
Conversation
Need to update the doctests to agree with this. |
Here is an example of how failing tests look like, taken from some tests of a private package of mine:
|
I've updated the doctests by running make.jl with A few of this packages unit tests are failing, but it seems to me that this is not to do with this PR. If this is incorrect I will investigate further. |
I've expanded the docs a bit by messing up the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good, can you fix the errors reported by CI?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 93.50% 93.71% +0.21%
==========================================
Files 12 12
Lines 354 350 -4
==========================================
- Hits 331 328 -3
+ Misses 23 22 -1 ☔ View full report in Codecov by Sentry. |
That should do it for the main CI tests. |
Regarding the failing CI tests for ChainRules - I think this is a separate issue but I don't know why it happens. These are type inference related tests failing for
|
yes, that is unrelated |
A small PR to help debugging packages once tests fail.
test_rrule
now indicates which cotangent did not match the finite difference result, which helps to narrow down bugs.