Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ZeroBundle wrapping for GlobalRef PhiNode args #218

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

oxinabox
Copy link
Member

This is just retargetting #212 against main.

These are not legal to insert in-place. Thankfully, since these are just
constants anyway we can evaluate the result in-place.
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (18cc1cb) 55.05% compared to head (a7f2986) 55.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   55.05%   55.05%           
=======================================
  Files          28       28           
  Lines        2810     2810           
=======================================
  Hits         1547     1547           
  Misses       1263     1263           
Files Coverage Δ
src/codegen/forward_demand.jl 45.41% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox oxinabox merged commit b3e4ee0 into main Sep 27, 2023
@oscardssmith oscardssmith deleted the ox/reland-phi-fix branch September 27, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants