Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map in forwards mode #224

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Fix map in forwards mode #224

merged 4 commits into from
Oct 11, 2023

Conversation

oxinabox
Copy link
Member

This is sliced out of #221
since that stuff is going to take a bit more thinking.

but this is an obvious and easy bug fix.
Both tests errored before these changes and now they do not.

Arguably we should delete Diffractors sepecial handling of map all together and leave that to ChainRules.
But that is a bigger PR.
Also requires fixing #222 (which might be easy)

@oxinabox oxinabox requested a review from oscardssmith October 10, 2023 10:45
@oscardssmith
Copy link
Member

this looks good, but you should probably define equality and hashing such that different representations of the same bundle end up equal

@oxinabox
Copy link
Member Author

the PR to do that ended up being more involved than you would think.
So I will make it as a follow up

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b3e4ee0) 55.05% compared to head (fb1dd92) 55.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   55.05%   55.76%   +0.71%     
==========================================
  Files          28       28              
  Lines        2810     2819       +9     
==========================================
+ Hits         1547     1572      +25     
+ Misses       1263     1247      -16     
Files Coverage Δ
src/tangent.jl 60.29% <90.90%> (+13.83%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox oxinabox merged commit e7c8abd into main Oct 11, 2023
5 of 8 checks passed
@oxinabox oxinabox deleted the ox/mapfix branch October 11, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants