Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward_visit!: Don't break on stmt-level Expr(:boundscheck) #226

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

Keno
Copy link
Collaborator

@Keno Keno commented Oct 11, 2023

The default transform should be fine.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e7c8abd) 55.76% compared to head (bc07dd0) 55.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   55.76%   55.72%   -0.04%     
==========================================
  Files          28       28              
  Lines        2819     2821       +2     
==========================================
  Hits         1572     1572              
- Misses       1247     1249       +2     
Files Coverage Δ
src/codegen/forward_demand.jl 45.02% <0.00%> (-0.40%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oscardssmith oscardssmith merged commit 4aab1d7 into main Oct 12, 2023
3 of 8 checks passed
@oscardssmith oscardssmith deleted the kf/boundscheckexpr branch October 12, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants