Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new AbstractDifferentiation.jl #255

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Conversation

MasonProtter
Copy link
Contributor

@MasonProtter MasonProtter commented Jan 31, 2024

Potential alternative to #228

There's something weird and wrong happening with failing tests though. If I include all the stuff into my REPL, @test_broken behaves properly, but if I actually do ] test then a bunch of them propagate their failures outside of the @test_broken so I had to manually comment them out to get them to behave.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.87%. Comparing base (6f1bdf0) to head (bfe284d).
Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   55.11%   54.87%   -0.25%     
==========================================
  Files          28       28              
  Lines        2892     2892              
==========================================
- Hits         1594     1587       -7     
- Misses       1298     1305       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MasonProtter
Copy link
Contributor Author

bump @oxinabox

@oxinabox oxinabox closed this Feb 26, 2024
@oxinabox oxinabox reopened this Feb 26, 2024
@oxinabox oxinabox merged commit 894ee3c into JuliaDiff:main Feb 26, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants