-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old code and test cleanup #464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metal Benchmarks
Benchmark suite | Current: b86748d | Previous: 100f831 | Ratio |
---|---|---|---|
private array/construct |
25763.916666666664 ns |
26340.333333333332 ns |
0.98 |
private array/broadcast |
472458 ns |
465791 ns |
1.01 |
private array/random/randn/Float32 |
768208 ns |
827937.5 ns |
0.93 |
private array/random/randn!/Float32 |
667250 ns |
635250 ns |
1.05 |
private array/random/rand!/Int64 |
574833 ns |
562291.5 ns |
1.02 |
private array/random/rand!/Float32 |
600584 ns |
594500 ns |
1.01 |
private array/random/rand/Int64 |
789166.5 ns |
801791 ns |
0.98 |
private array/random/rand/Float32 |
658750 ns |
591208 ns |
1.11 |
private array/copyto!/gpu_to_gpu |
572209 ns |
645500 ns |
0.89 |
private array/copyto!/cpu_to_gpu |
834209 ns |
618187.5 ns |
1.35 |
private array/copyto!/gpu_to_cpu |
627291.5 ns |
798500 ns |
0.79 |
private array/accumulate/1d |
1403375 ns |
1333083 ns |
1.05 |
private array/accumulate/2d |
1414104 ns |
1424500 ns |
0.99 |
private array/iteration/findall/int |
2167625 ns |
2100167 ns |
1.03 |
private array/iteration/findall/bool |
1901958 ns |
1847000 ns |
1.03 |
private array/iteration/findfirst/int |
1716583 ns |
1696166.5 ns |
1.01 |
private array/iteration/findfirst/bool |
1655562.5 ns |
1651958.5 ns |
1.00 |
private array/iteration/scalar |
3918542 ns |
3657771 ns |
1.07 |
private array/iteration/logical |
3299604.5 ns |
3264437.5 ns |
1.01 |
private array/iteration/findmin/1d |
1578083.5 ns |
1565166 ns |
1.01 |
private array/iteration/findmin/2d |
1336937.5 ns |
1351333.5 ns |
0.99 |
private array/reductions/reduce/1d |
1064500 ns |
1063291 ns |
1.00 |
private array/reductions/reduce/2d |
680333 ns |
695645.5 ns |
0.98 |
private array/reductions/mapreduce/1d |
1073542 ns |
1078084 ns |
1.00 |
private array/reductions/mapreduce/2d |
682334 ns |
705166 ns |
0.97 |
private array/permutedims/4d |
2918667 ns |
860084 ns |
3.39 |
private array/permutedims/2d |
1039208 ns |
862229.5 ns |
1.21 |
private array/permutedims/3d |
1613563 ns |
919520.5 ns |
1.75 |
private array/copy |
564916 ns |
574854 ns |
0.98 |
latency/precompile |
4512136625 ns |
4396587542 ns |
1.03 |
latency/ttfp |
6842745646 ns |
6698494124.5 ns |
1.02 |
latency/import |
879455125 ns |
722852834 ns |
1.22 |
integration/metaldevrt |
746417 ns |
719875 ns |
1.04 |
integration/byval/slices=1 |
1554396 ns |
1530167 ns |
1.02 |
integration/byval/slices=3 |
10410854.5 ns |
9115541.5 ns |
1.14 |
integration/byval/reference |
1561250 ns |
1520271 ns |
1.03 |
integration/byval/slices=2 |
2650646 ns |
2666416 ns |
0.99 |
kernel/indexing |
468417 ns |
468541 ns |
1.00 |
kernel/indexing_checked |
474583 ns |
461292 ns |
1.03 |
kernel/launch |
8750 ns |
8834 ns |
0.99 |
metal/synchronization/stream |
14500 ns |
14583 ns |
0.99 |
metal/synchronization/context |
15125 ns |
15250 ns |
0.99 |
shared array/construct |
26500 ns |
26069.5 ns |
1.02 |
shared array/broadcast |
486000 ns |
468333 ns |
1.04 |
shared array/random/randn/Float32 |
835146 ns |
785583 ns |
1.06 |
shared array/random/randn!/Float32 |
670084 ns |
626541.5 ns |
1.07 |
shared array/random/rand!/Int64 |
570625 ns |
564084 ns |
1.01 |
shared array/random/rand!/Float32 |
613125 ns |
598792 ns |
1.02 |
shared array/random/rand/Int64 |
813917 ns |
788666 ns |
1.03 |
shared array/random/rand/Float32 |
649917 ns |
629791 ns |
1.03 |
shared array/copyto!/gpu_to_gpu |
90041 ns |
96916 ns |
0.93 |
shared array/copyto!/cpu_to_gpu |
87958 ns |
88583 ns |
0.99 |
shared array/copyto!/gpu_to_cpu |
77292 ns |
83458 ns |
0.93 |
shared array/accumulate/1d |
1390750 ns |
1356667 ns |
1.03 |
shared array/accumulate/2d |
1414416 ns |
1421333 ns |
1.00 |
shared array/iteration/findall/int |
1865333.5 ns |
1792833 ns |
1.04 |
shared array/iteration/findall/bool |
1650291 ns |
1620166.5 ns |
1.02 |
shared array/iteration/findfirst/int |
1403708 ns |
1385791 ns |
1.01 |
shared array/iteration/findfirst/bool |
1361688 ns |
1376291 ns |
0.99 |
shared array/iteration/scalar |
155583 ns |
151458 ns |
1.03 |
shared array/iteration/logical |
3088125 ns |
3042333 ns |
1.02 |
shared array/iteration/findmin/1d |
1277833 ns |
1274875 ns |
1.00 |
shared array/iteration/findmin/2d |
1352562.5 ns |
1346333 ns |
1.00 |
shared array/reductions/reduce/1d |
735958 ns |
694458 ns |
1.06 |
shared array/reductions/reduce/2d |
682000 ns |
702292 ns |
0.97 |
shared array/reductions/mapreduce/1d |
759958 ns |
754229 ns |
1.01 |
shared array/reductions/mapreduce/2d |
684854 ns |
705395.5 ns |
0.97 |
shared array/permutedims/4d |
2949041 ns |
858875 ns |
3.43 |
shared array/permutedims/2d |
1044917 ns |
862292 ns |
1.21 |
shared array/permutedims/3d |
1607875 ns |
923916.5 ns |
1.74 |
shared array/copy |
239958 ns |
246583 ns |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Needs rebase.
Test failure unrelated and reported (#466). |
Mark as broken for now? |
We don't support macOS version prior to 13 so remove related code.
Also replace some uses of
x == nothing
tox === nothing
.Diff best looked at with "hide whitespace" option