Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GeoData export #134

Merged
merged 2 commits into from
Jul 29, 2024
Merged

fix GeoData export #134

merged 2 commits into from
Jul 29, 2024

Conversation

aelligp
Copy link
Collaborator

@aelligp aelligp commented Jul 24, 2024

This PR fixes cross_section_surface to export the correct AbstractGeneralGrid type rather than only GeoData:

    if isa(S,GeoData)
        Data_profile = GeoData(Lon, Lat, depth_intp, fields_new);
    elseif isa(S,CartData)
        Data_profile = CartData(Lon, Lat, depth_intp, fields_new);
    else
        error("still to be implemented")
    end

@aelligp aelligp requested a review from boriskaus July 24, 2024 09:02
Copy link
Member

@boriskaus boriskaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

If you add a test for this, CodeCov will be happy

@boriskaus boriskaus merged commit fdd372a into main Jul 29, 2024
23 checks passed
@boriskaus boriskaus deleted the pa-cross branch July 29, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants