Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add surfaces routines #78

Merged
merged 17 commits into from
Mar 4, 2024
Merged

Add surfaces routines #78

merged 17 commits into from
Mar 4, 2024

Conversation

boriskaus
Copy link
Member

@boriskaus boriskaus commented Mar 2, 2024 •
edited
Loading

This PR:

  • moves a few surface-relates routines to a separate file (cleaning up utils.jl)
  • added new routines that allow to add and subtract surfaces
  • renames all related functions to start with lower-case letters (issue Function names #77) which results in quite a few changed files
  • adds 1D/2D/3D nearest point routines (as we use them quite frequently)

@boriskaus boriskaus requested a review from aelligp March 2, 2024 21:28
aelligp
aelligp requested changes Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@aelligp aelligp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just a minor change in the authors, otherwise good

AUTHORS.md Outdated Show resolved Hide resolved
@boriskaus boriskaus requested a review from mthielma March 4, 2024 07:12
mthielma
mthielma approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@mthielma mthielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and definitely cleans up utils.jl.

@boriskaus boriskaus requested a review from aelligp March 4, 2024 08:21
@boriskaus boriskaus merged commit 0170599 into main Mar 4, 2024
24 checks passed
@boriskaus boriskaus deleted the bk-points-to-surface branch March 4, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelligp aelligp aelligp approved these changes

@mthielma mthielma mthielma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boriskaus @mthielma @aelligp