Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Homebrew check #227

Merged
merged 1 commit into from
Jun 2, 2018
Merged

remove Homebrew check #227

merged 1 commit into from
Jun 2, 2018

Conversation

jonathanBieler
Copy link
Contributor

This doesn't work on v0.7 because Pkg.installed doesn't take a String anymore. While it could be fixed with Compat I propose to remove the check since the error message for using Homebrew is very similar and we don't do the check for windows. Homebrew is also in REQUIRE so it should be installed.

@coveralls
Copy link

coveralls commented May 29, 2018

Coverage Status

Coverage remained the same at 90.828% when pulling 6606e2a on jonathanBieler:pull-request/6606e2af into f1bd654 on JuliaGraphics:master.

@lobingera
Copy link
Contributor

@jonathanBieler Looks reasonable. Do you think the failing test (travis, nightly, macos) is related?

@tknopp
Copy link
Contributor

tknopp commented Jun 2, 2018

@lobingera I can confirm that this make Cairo usable under 0.7 / Mac again. travis seems to be another issue

@lobingera lobingera merged commit e34d721 into JuliaGraphics:master Jun 2, 2018
@aviks
Copy link

aviks commented Jun 4, 2018

Is this worth a new release please?

@lobingera
Copy link
Contributor

Is this urgent and solving someone's problem? I'd like to update some deprecation warnings also, get 0.7 testing badge and find a solution for #223 which seems to be a side effect of the replacement of 'importall'. Time horizon: This weekend.

@aviks
Copy link

aviks commented Jun 4, 2018

Yes, of course. I was stuck, but a Cairo#master has let me progress for the moment. Thanks!

@aviks
Copy link

aviks commented Jun 4, 2018

And, to add, I've been troubled by #223 as well (on 0.6, mac), so a fix for that would be much appreciated!

@tknopp
Copy link
Contributor

tknopp commented Jun 4, 2018

Transition to 0.7 seems to require a step-by step approach. First the "leaf-packages" need to migrate 0.7 and then make a release. As a depending package (like Winston.jl) first the dependencies need to get ready. Cairo is of course pretty close to a leaf package.

@lobingera
Copy link
Contributor

lobingera commented Jun 4, 2018

OK, I'll look into #223 tomorrow again, but even if this is not solved - my guess it's the import of types from Graphics.jl - I'll do a release
@tknopp , @aviks Anything else that needs to be included?

@aviks
Copy link

aviks commented Jun 4, 2018

Cairo is of course pretty close to a leaf package

And hence I'm here. @tknopp I'll ask about Gtk next. :)

@tknopp
Copy link
Contributor

tknopp commented Jun 4, 2018

@aviks: I kind of feared that. Fortunately @jonathanBieler has (almost?) finished the port: https://github.com/JuliaGraphics/Gtk.jl/tree/teh/partial0.7

@lobingera
Copy link
Contributor

@tknopp ,@aviks, 0.5.2 is tagged. I had no time to look into #223.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants