-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Homebrew check #227
remove Homebrew check #227
Conversation
@jonathanBieler Looks reasonable. Do you think the failing test (travis, nightly, macos) is related? |
@lobingera I can confirm that this make Cairo usable under 0.7 / Mac again. travis seems to be another issue |
Is this worth a new release please? |
Is this urgent and solving someone's problem? I'd like to update some deprecation warnings also, get 0.7 testing badge and find a solution for #223 which seems to be a side effect of the replacement of 'importall'. Time horizon: This weekend. |
Yes, of course. I was stuck, but a |
And, to add, I've been troubled by #223 as well (on 0.6, mac), so a fix for that would be much appreciated! |
Transition to 0.7 seems to require a step-by step approach. First the "leaf-packages" need to migrate 0.7 and then make a release. As a depending package (like Winston.jl) first the dependencies need to get ready. Cairo is of course pretty close to a leaf package. |
And hence I'm here. @tknopp I'll ask about Gtk next. :) |
@aviks: I kind of feared that. Fortunately @jonathanBieler has (almost?) finished the port: https://github.com/JuliaGraphics/Gtk.jl/tree/teh/partial0.7 |
This doesn't work on v0.7 because
Pkg.installed
doesn't take a String anymore. While it could be fixed with Compat I propose to remove the check since the error message forusing Homebrew
is very similar and we don't do the check for windows. Homebrew is also inREQUIRE
so it should be installed.