Import missing functions from Graphics. #254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #216,
importall Graphics
was converted to a list of more specific imports, sinceimportall
was being deprecated. That list is not complete, however, as can be witnessed byOne effect of this is that
text
functioncomputes a bogus bounding box when device and user coordinates are not the same.
Graphics.device_to_user
is a thin wrapper that repackages the data and callsdevice_to_user!
. This is supposed to dispatch back to Cairo but sinceCairo.device_to_user!
is currently a separate function fromGraphics.device_to_user!
, instead the do nothing fallback definition inGraphics
is used and coordinates are not transformed.This PR adds all those missing functions to the import list.