-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cache mechanism #76
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 94.62% // Head: 95.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 94.62% 95.31% +0.69%
==========================================
Files 6 6
Lines 316 320 +4
==========================================
+ Hits 299 305 +6
+ Misses 17 15 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
How would saving these path strings during compilation play with relocation? Seems to me that it would break if you'd move a sysimage with baked in paths somewhere else. I guess fonts are difficult in that way as they could be in different places on different systems. For Makie, we really only care about not triggering font search in the default case, correct? In that case, we should look into caching Makie's default fonts in a relocatable way. That's only a couple fonts, mostly the four Makie TeX Gyre Heros fonts and a few fallbacks. If those fonts are already known at load, we wouldn't get latencies until the user specifies a new font for the first time. |
In this PR in FTA, the cache is invalidated on
There are a few options here, but fully caching the font might not be feasible (because of the FT handles opened). What I aim at least for #67 (comment) is trying to cache a few font paths for defaults as done here avoiding re-running the costly search and trial + best score approach of |
I did mean caching the path, yes. Just in some relocatable way. |
I've added a failsafe in Makie. For now, if the path is non-existent, just fallback to using |
Fix #67.