Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for exec_async #185

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Fix for exec_async #185

merged 3 commits into from
Oct 16, 2023

Conversation

barche
Copy link
Collaborator

@barche barche commented Oct 14, 2023

Issue exec_async crashes #174

Issue `exec_async` crashes #174
@ufechner7
Copy link
Member

Any idea why it works with Julia 1.6 on Linux, but fails on 1.9 with:

functions.jl: Error During Test at /home/runner/work/QML.jl/QML.jl/test/runtests.jl:14
  Got exception outside of a @test
  LoadError: Storing a null function pointer in a JuliaFunction is not allowed

@barche barche force-pushed the async-fix branch 2 times, most recently from 580f842 to 6ddbcac Compare October 15, 2023 21:03
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5614e6a) 88.81% compared to head (20cdd00) 89.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   88.81%   89.32%   +0.51%     
==========================================
  Files           3        2       -1     
  Lines         438      384      -54     
==========================================
- Hits          389      343      -46     
+ Misses         49       41       -8     
Files Coverage Δ
src/QML.jl 96.98% <33.33%> (+0.45%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@barche barche merged commit 0b987e2 into main Oct 16, 2023
9 of 12 checks passed
@barche barche deleted the async-fix branch October 16, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants