Revert "Align writeas for Dict with wconvert" #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
=======================================
Coverage 85.95% 85.95%
=======================================
Files 31 31
Lines 4229 4230 +1
=======================================
+ Hits 3635 3636 +1
Misses 594 594
☔ View full report in Codecov by Sentry. |
|
I'll implement the fix tomorrow. |
|
Okay I will tag a patch release temporarily so stable releases of Julia are not broken. The original change was for nightly AFAICT |
|
Oh I just saw #499 |
|
The #499 should work for both nightly and with non standard dict types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #492
Re #497
Should likely have a patch release or alternative fix.