Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental disable commit #544

Merged
merged 2 commits into from
Aug 25, 2024
Merged

experimental disable commit #544

merged 2 commits into from
Aug 25, 2024

Conversation

JonasIsensee
Copy link
Collaborator

Set JLD2.DISABLE_COMMIT[] = true to throw errors instead of committing types to files.
Can be used to guarantee plain files.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.92%. Comparing base (dd7c9b0) to head (f145b95).
Report is 1 commits behind head on dev.

Files Patch % Lines
src/data/writing_datatypes.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #544   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files          36       36           
  Lines        4463     4470    +7     
=======================================
+ Hits         3790     3796    +6     
- Misses        673      674    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonasIsensee JonasIsensee changed the base branch from master to dev August 24, 2024 12:18
@JonasIsensee JonasIsensee merged commit 140dc81 into dev Aug 25, 2024
15 checks passed
JonasIsensee added a commit that referenced this pull request Aug 26, 2024
* fix attribute loading

* Update ci.yml

* WIP: Mmappable Arrays (#582)

* wip: mmappable arrays

* tests

* include mmap_test

* disable broken mmap on windows

* update warning test

* downgrade testing (#547)

* downgrade testing

* bump compat for Requires

* bump compat for FileIO

* rm UUIDs

* skip Mmap

* remove test that only tests a FileIO feature

---------

Co-authored-by: Jonas Isensee <[email protected]>

* experimental disable commit (#544)

* experimental disable commit

* 1.6 compat and make disable_commit a field of the file

* some code cleanup

* get rid of StorageMessage structs

* chunked storage fix

* clean up filterpipeline

* Draft: experimental plain reconstruction (#522)

* experimental plain reconstruction

* Upgrade

* add test

---------

Co-authored-by: Jonas Isensee <[email protected]>
@JonasIsensee JonasIsensee deleted the disablecommit branch August 27, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant