Call xmlSubstituteEntitiesDefault before parsing #42
Conversation
|
bump |
| @@ -85,12 +85,14 @@ end | |||
| #### parse and free | |||
|
|
|||
| function parse_file(filename::AbstractString) | |||
| ccall((:xmlSubstituteEntitiesDefault, libxml2), Cint, (Cint,), Int(1)) | |||
|
bump again... |
|
Could you squash the two commits into a single one? |
Given that LightXML does not support XML Entities, asking LibXML to expand entities while parsing seems like the right thing to do...
|
rebase/squashed |
|
Looks good to me, but since I know nothing about this package I'll leave @tkelman press the button. Also, maybe this should be tested? Else it might break without anybody noticing and you'll likely be the first victim. |
|
I'll leave it to @tkelman to decide if he thinks this change breaks anything or if he want's to add more tests. |
I'm not particularly interested in this, but if you want to be sure this continues working, you'd better move some of them here. Else you'll only notice the breakage after a LightXML release has been tagged. |
|
What does this accomplish, why is it necessary, what are the impacts? If there's a nonzero cost to doing this by default so you may have a reason to want to maintain the existing behavior, maybe a boolean keyword argument to enable or disable this? |
Given that LightXML does not support XML Entities, asking LibXML to expand entities while parsing seems like the right thing to do...