add shortcuts for closing and fullscreening window #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 84.76% 86.04% +1.28%
==========================================
Files 6 6
Lines 840 860 +20
==========================================
+ Hits 712 740 +28
+ Misses 128 120 -8 ☔ View full report in Codecov by Sentry. |
It works for me locally but apparently not in CI
also belatedly update NEWS for v0.12
It has nothing to do with this PR. Also update CI action versions and use julia-cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds keyboard shortcuts for closing windows (Ctrl-W on Linux and Windows, Command-W on Mac) and fullscreening windows (F11 on Linux and Windows, Command-Shift-F on Mac). Only applies to windows created by ImageView, i.e. not user-created windows inside which ImageView widgets are placed.
Also fixes an issue with tests and works around a sporadic test failure on Mac OS that has nothing to do with this PR.