Add UnresolvedRuntimeCall for unresolved function calls
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can occasionally happen due to known incomplete spots in our call resolution (#69) or due to changes in the optimizer, etc. Rather than conservatively calling these "dynamic dispatches", this adds a new error type that encourages the user to file a bug upstream, since a feature-complete AllocCheck should never encounter them.
topolarity
force-pushed
the
ct/unresolved
branch
from
1786643 to
f7ab19c
Compare
|
Hmm, this is a bit in conflict with OpaqueClosures, which are literally unresolvable function calls (that should be correctly classified as dynamic dispatches) This might still be the right direction to go until OpaqueClosures are more widely used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can occasionally happen due to known incomplete spots or bugs in our call resolution (see #77)
Rather than conservatively calling these "dynamic dispatches", this adds a new error type that encourages the user to file a bug with us upstream, since a feature-complete AllocCheck should never encounter them.