Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AArch64 arithmetic on LLVM 19. #77

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Aug 14, 2024

x-ref JuliaLang/julia#55486 (comment)

Draft until we can test this, i.e., when there's a LLVM 19 PR on the Julia repository.
Version bound determined by building LLVM 19 locally, using: https://godbolt.org/z/7oGoMWrax

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.74%. Comparing base (2266cc5) to head (fba12ad).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   65.74%   65.74%           
=======================================
  Files           3        3           
  Lines         181      181           
=======================================
  Hits          119      119           
  Misses         62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt
Copy link
Member Author

maleadt commented Aug 14, 2024

I built Julia against LLVM 19, JuliaLang/julia#55486 (comment), and everything seems to work fine. So let's go ahead and merge this.

Julia Version 1.12.0-DEV.1047
Commit 3c4cc92d88* (2024-08-14 06:12 UTC)
Platform Info:
  OS: macOS (arm64-apple-darwin23.6.0)
  CPU: 11 × Apple M3 Pro
  WORD_SIZE: 64
  LLVM: libLLVM-19.1.0 (ORCJIT, apple-m3)
Threads: 1 default, 0 interactive, 1 GC (on 5 virtual cores)
Environment:
  JULIA_PKG_SERVER_REGISTRY_PREFERENCE = eager
  JULIA_PKG_USE_CLI_GIT = true
  JULIA_PKG_DEVDIR = /Users/tim/Julia/pkg
┌ Info: Testing BFloat16s
│   BFloat16s.llvm_storage = true
└   BFloat16s.llvm_arithmetic = true
Test Summary: | Pass  Total  Time
comparisons   |   17     17  0.0s
Test Summary: | Pass  Total  Time
conversions   |    4      4  0.0s
Test Summary: | Pass  Total  Time
abi           |    2      2  0.0s
Test Summary: | Pass  Total  Time
functions     |    8      8  0.0s
Test Summary: | Pass  Total  Time
arithmetic    |    6      6  0.0s
Test Summary: | Pass  Total  Time
printf        |   23     23  0.2s
Test Summary: | Pass  Total  Time
random        |    6      6  0.1s
Test Summary: | Pass  Total  Time
round         |    1      1  0.0s
Test Summary:  | Pass  Total  Time
Next/prevfloat |   15     15  0.0s
Test Summary:      | Pass  Total  Time
Decompose BFloat16 |  100    100  0.0s
Test Summary:               | Pass  Total  Time
Next/prevfloat(x,::Integer) |    9      9  0.0s
Test Summary: | Pass  Total  Time
maxintfloat   |    2      2  0.0s
Test Summary: | Pass  Total  Time
BFloat16 bits |    3      3  0.0s
Test Summary:  | Pass  Total  Time
BFloat16 parts |    9      9  0.0s
     Testing BFloat16s tests passed

@maleadt maleadt merged commit b5312dd into master Aug 14, 2024
7 checks passed
@maleadt maleadt deleted the tb/aarch64_arithmetic branch August 14, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant