Fix inf and nan bugs #204
Merged
Fix inf and nan bugs #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 50.42% 50.46% +0.04%
==========================================
Files 63 63
Lines 3536 3537 +1
==========================================
+ Hits 1783 1785 +2
+ Misses 1753 1752 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199, fixes #201, fixes #203
I thought these bugs had been cause by my recent PR, so I felt I had the duty to fix them. It turns out only #199 was my fault, but since I investigated the other ones anyway I went ahead and fixed them.
It turned out that my PR had been complete nonsense, and it certainly had caused other bugs that went unnoticed, so this time I went through the code thoroughly to make everything consistent. The result might be a bit too intrusive for your taste.