use global symbols on Unix to support LD_PRELOAD interception #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - I'll try this hopefully later today. |
lyon-fnal
reviewed
Jan 5, 2021
|
Does this make JuliaIO/HDF5.jl#791 unecessary ? Also note Mose's reply in JuliaIO/HDF5.jl#791 (comment) |
|
No, but you could use the same trick (macro wrapper around |
|
Sorry - couldn't get back to this until now. I'm trying it! |
|
It works fine on my simple test! |
|
Thanks. @vchuravy any additional thoughts before we merge? |
|
I'm trying a more complex test and with the package compiler. |
|
My complex test worked. I didn't get much info out of Darshan, because I'm not doing collective MPI-IO. But that's not your problem :-) . If you are waiting on me to merge, I think you can go ahead. Thanks! |
|
Thanks @lyon-fnal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #450 that only uses global symbols on unix systems.
@lyon-fnal would you be able to try this out?