Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROCm-aware MPI extension #763

Merged
merged 6 commits into from
Sep 5, 2023
Merged

Fix ROCm-aware MPI extension #763

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7e4bee
Add `.vscode/` to `.gitignore`
utkinis Sep 5, 2023
6f30b0f
Fix conversion to Ptr
utkinis Sep 5, 2023
836fc70
Update compat bounds
utkinis Sep 5, 2023
cbaffb2
Update compat bounds
utkinis Sep 5, 2023
e07d589
Update .gitignore
simonbyrne Sep 5, 2023
d2c29ec
bump patch
simonbyrne Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@
*.mem
Manifest.toml
LocalPreferences.toml

.vscode/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in your own excludes file, see https://git-scm.com/docs/gitignore

simonbyrne marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Serialization = "9e88b42a-f829-5b0c-bbe9-9e923198166b"
Sockets = "6462fe0b-24de-5631-8697-dd941f90decc"

[compat]
AMDGPU = "0.3, 0.4, 0.5"
AMDGPU = "0.5.7"
CUDA = "3, 4"
DocStringExtensions = "0.8, 0.9"
MPIPreferences = "0.1.8"
Expand Down
2 changes: 1 addition & 1 deletion ext/AMDGPUExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function Base.cconvert(::Type{MPIPtr}, A::AMDGPU.ROCArray{T}) where T
end

function Base.unsafe_convert(::Type{MPIPtr}, X::AMDGPU.ROCArray{T}) where T
reinterpret(MPIPtr, Base.unsafe_convert(Ptr{T}, X.buf.ptr+X.offset))
reinterpret(MPIPtr, Base.unsafe_convert(Ptr{T}, X))
end

# only need to define this for strided arrays: all others can be handled by generic machinery
Expand Down