-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat major and minor ticks differently (in GR, for now) #1788
Conversation
has an effect on GR only
As laid out in #1794 I could delete the |
@@ -1283,6 +1285,8 @@ const _match_map2 = KW( | |||
:fontfamily_subplot => :fontfamily, | |||
:tickfontfamily => :fontfamily_subplot, | |||
:guidefontfamily => :fontfamily_subplot, | |||
:foreground_color_tick => :foreground_color_subplot, | |||
:foreground_color_minortick => :foreground_color_subplot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add these to _match_map
instead and let them default to :foreground_color_axis
(which then defaults to :foreground_color_subplot
). Then you should be able to have different tick colors for different axis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @greimel would you mind doing this minor change so we can get this merged? Thanks!
Sorry for not finishing this PR. I've not used Plots.jl for a year or two. Please feel free to take the code or close the PR. |
It was decided in the last maintainer call (#3538) that rebasing this PR is not worth the effort and that we'd need a reimplementation of this on the current state of Plots. |
Totally missed this maintainers' call, is there a reminder thread or something? @BeastyBlacksmith |
You should have got an email. If not hit me on zulip. |
I am working on a theme that resembles the default theme of
ggplot2
(JuliaPlots/PlotThemes.jl/pull/30).The goal is this:
Note that
ggplot2
doesn't show ticks for minor grid lines. This is not currently possible in plots.The first commit partly solves the problem for
gr()
.I compute the minor grids separately and assign them the color of the border. This would in principle solve my problem. However, I do not like this fix yet. I would like to add a new attribute
foreground_color_minor_ticks
or similar to set this color. I tried to do this, but got an error that I do not understand. Unfortunately I know too little aboutPlots.jl
.Could someone look at my last commit and guide me a bit in proceeding here?
PS: I propose to introduce an attribute
foreground_color_major_ticks
as well. It's not yet clear to me what the exact purpose offoreground_color_axis
andforeground_color_border
are (see my previous PR #1787)