Fix poor performance when one of batch
's arguments is a Type{...}
#139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #116 by wrapping each argument of
batch
in awrap_type
function and usingunwrap_type
before the start of the loop body, as @chriselrod suggested. A test is included in runtests.jl.Also made it such that
batch
always returns an emptyTuple
whenreduction
is not used, since it used to be aUnion{Nothing, Tuple{}}
.