fix: handle CallWithMetadata in var_from_nested_derivative #1300
Conversation
|
Why is CI failing to install sympy? |
|
Julia 1.11 maybe? |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1300 +/- ##
===========================================
+ Coverage 30.06% 78.89% +48.82%
===========================================
Files 47 47
Lines 4576 4686 +110
===========================================
+ Hits 1376 3697 +2321
+ Misses 3200 989 -2211 ☔ View full report in Codecov by Sentry. |
| @@ -101,15 +102,15 @@ ComponentArrays = "b0b7db55-cfe3-40fc-9ded-d10e2dbeff66" | |||
| DynamicQuantities = "06fc5a27-2a28-4c7c-a15d-362465fb6821" | |||
| ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210" | |||
| Groebner = "0b43b601-686d-58a3-8a1c-6623616c7cd4" | |||
| LambertW = "984bce1d-4616-540c-a9ee-88d1112d94c9" | |||
There was a problem hiding this comment.
Line 524 in 6271c8b
It's used in a test but never added as a test dep. I'm guessing it used to be transitively loaded, but isn't now.
| Lux = "b2108857-7c20-44ae-9111-449ecde12c47" | ||
| Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f" | ||
| PkgBenchmark = "32113eaa-f34f-5b0d-bd6c-c81e245fc73d" | ||
| PreallocationTools = "d236fae5-4411-538c-8e31-a6e3d9e00b46" | ||
| Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" | ||
| ReferenceTests = "324d217c-45ce-50fc-942e-d289b448e8cf" | ||
| SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f" | ||
| SymPy = "24249f21-da20-56a4-8eb1-6a02cf4ae2e6" |
There was a problem hiding this comment.
send it to a separate test group
AayushSabharwal
force-pushed
the
as/callables-fix
branch
from
e47636b to
ac511a2
Compare
|
Why does it say it passed now? 😅 https://github.com/JuliaSymbolics/Symbolics.jl/actions/runs/11292511039/job/31408644761?pr=1300#step:7:885 |
ChrisRackauckas
merged commit af8a07c
into
JuliaSymbolics:master
No description provided.