Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_scalar_metadata to set metadata scalar-wise #984

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Conversation

YingboMa
Copy link
Member

@YingboMa YingboMa commented Oct 4, 2023

No description provided.

@YingboMa
Copy link
Member Author

YingboMa commented Oct 4, 2023

Note that the new function is implicitly tested by setdefaultval

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Merging #984 (1a74a87) into master (0c91be9) will decrease coverage by 68.62%.
The diff coverage is 14.28%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #984       +/-   ##
==========================================
- Coverage   77.32%   8.71%   -68.62%     
==========================================
  Files          26      26               
  Lines        3356    3306       -50     
==========================================
- Hits         2595     288     -2307     
- Misses        761    3018     +2257     
Files Coverage Δ
src/variable.jl 30.48% <14.28%> (-39.03%) ⬇️

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YingboMa YingboMa merged commit 6e33cfc into master Oct 4, 2023
11 of 17 checks passed
@YingboMa YingboMa deleted the myb/md branch October 4, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants