Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

30 add aquajl #31

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

30 add aquajl #31

wants to merge 7 commits into from

Conversation

pat-alt
Copy link
Member

@pat-alt pat-alt commented Sep 5, 2024

  • Fixes FormatCheck.yml to ensure that test actually fails if necessary
  • Adds quality assurance through Aqua.jl

@pat-alt pat-alt linked an issue Sep 5, 2024 that may be closed by this pull request
@pat-alt pat-alt mentioned this pull request Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 39.28571% with 17 lines in your changes missing coverage. Please review.

Project coverage is 40.83%. Comparing base (a02d3e9) to head (87d8df9).

Files with missing lines Patch % Lines
src/attacks/square/square_attack.jl 0.00% 5 Missing ⚠️
src/training/adversarial_training.jl 0.00% 4 Missing ⚠️
src/attacks/autopgd/utils.jl 40.00% 3 Missing ⚠️
src/attacks/square/utils.jl 0.00% 3 Missing ⚠️
src/attacks/common_utils.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   41.32%   40.83%   -0.49%     
==========================================
  Files          10       10              
  Lines         242      240       -2     
==========================================
- Hits          100       98       -2     
  Misses        142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pat-alt
Copy link
Member Author

pat-alt commented Sep 5, 2024

No changes to the actual code base except formatting. The rest is just related to house keeping/best practices, so don't think there's much to review here, but will request anyway and not bypass the rule @rithik83

@pat-alt pat-alt requested a review from rithik83 September 5, 2024 15:01
)
Random.seed!(0)
n_features = length(x)

# Initialization (stripes of +/-ϵ)
init_δ = rand(w, 1, c) .|> x -> x < 0.5 ? -ϵ : ϵ
init_δ = (x -> x < 0.5 ? -ϵ : ϵ).(rand(w, 1, c))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things like this do not change the functionality of the step, right? (not just this but in general towards all the tweaks within the attack algorithms)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no all of this is just automated formatting using JuliaFormatter.format(".")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Aqua.jl
2 participants