Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: kysely adapter + remove disconnect stuff #2

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Conversation

Julien-R44
Copy link
Owner

@Julien-R44 Julien-R44 commented Mar 11, 2024

This PR adds a new driver driver: kysely and a way to extend the database store with its own adapter ( kysely, knex, prisma ... )

will also create some breaking changes:

  • passing a Knex instance to the databaseStore is now mandatory. verrou don't create the instance anymore.
  • same for redis. you must provide your own ioredis instance
  • same for dynamodb.
  • the databaseStore is now named knexStore since we also have kyselyStore and drizzleStore
  • the disconnect methods no longer exist. since the user now has to pass his Knex/Kysely/Drizzle instance to Verrou, it's up to him to manually disconnect his database.

Todo

  • probably need to create something like a BaseDatabaseStore class, which will contain the common logic between the various stores to avoid duplicating certain parts of the code
  • remove disconnect things
  • update documentation

@Julien-R44 Julien-R44 changed the title feat: add kysely and drizzle adapters feat: kysely adapter + remove disconnect Mar 12, 2024
Copy link

cloudflare-workers-and-pages bot commented Mar 12, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 257971b
Status: ✅  Deploy successful!
Preview URL: https://c602f1b3.verrou.pages.dev
Branch Preview URL: https://feat-db-adapters.verrou.pages.dev

View logs

@Julien-R44 Julien-R44 marked this pull request as ready for review March 12, 2024 19:41
@Julien-R44 Julien-R44 changed the title feat: kysely adapter + remove disconnect feat!: kysely adapter + remove disconnect stuff Mar 12, 2024
@Julien-R44 Julien-R44 merged commit c493332 into main Mar 12, 2024
9 checks passed
@Julien-R44 Julien-R44 deleted the feat/db-adapters branch March 12, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant