refactor!: do not throw anymore when cant acquire a lock #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR changes a crucial element of Verrou that simplifies the control flow. Previously, the
acquire
,run
,acquireImmediately
etc. methods threw anE_LOCK_TIMEOUT
error if the lock could not be acquiredthis sometimes made the flow a little complicated and not super readable :
Now, the methods will simply return a boolean to indicate whether the lock has been acquired or not. Example with
acquire
andacquireImmediately
.much simpler and easier to read this way.
for
run
andrunImmediately
it's a bit different. The functions now return tuples. Before, you had to do it like this:And now, with the new version :